Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-9514 - Inflight Process Map > The process changes position with the mouse #1639

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

eiresendez
Copy link
Contributor

@eiresendez eiresendez commented Jul 31, 2023

Issue & Reproduction Steps

  1. Create a process
  2. Complete the process
  3. Go to Overview
  4. Drag the process

Expected behavior:

  • The process should not return to the initial state after dragging the container with the mouse

Actual behavior:

  • The process returns to the initial state as if it were spinning

Solution

  • Added missing condition for when the Modeler is in "read-only" mode.
    • This way, when panning and the mouse exits the paper area, the elements will NOT change position. Now, both the Overview tab and the Modeler share the same functionality.

Overview Tab Example:

Screen.Recording.2023-07-31.at.9.47.05.a.m.mov

Modeler Example:

Screen.Recording.2023-07-31.at.11.22.12.a.m.mov

How to Test

  • You can manually test in modeler standalone.
  • You can also manually test by linking modeler in Core and following the steps of above.

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@eiresendez eiresendez marked this pull request as ready for review July 31, 2023 16:18
@eiresendez eiresendez requested a review from nolanpro July 31, 2023 17:33
Copy link
Contributor

@nolanpro nolanpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected (chrome 115)

@ryancooley ryancooley merged commit 0b1b81f into develop Jul 31, 2023
14 of 17 checks passed
@ryancooley ryancooley deleted the observation/FOUR-8514 branch July 31, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants